Make power distributor resilient to battery inverters becoming unreachable#1373
Merged
shsms merged 5 commits intofrequenz-floss:v1.x.xfrom Mar 12, 2026
Merged
Conversation
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
This is just a place-holder for unreachable power. It will be calculated and used in subsequent commits. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
When a battery is unusable because its inverter is unreachable, we start a formula (with fallback from the component graph) to track its power. If the inverter is still functioning but only not reachable because of a network issue, its power will be excluded from the power to be distributed. This makes sure that we don't end up setting more power than what was requested. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
shsms
requested review from
ela-kotulska-frequenz
and removed request for
a team
github-actions
bot
added
part:docs
github-project-automation
bot
moved this from To do
to Review approved
in Python SDK Roadmap
Contributor
Author
|
Need to look into 1342, don't remember the issue anymore. Will do later. |
github-merge-queue
bot
removed this pull request from the merge queue due to Branch Protection failures
You're not authorized to push to this branch. Visit "About protected branches" for more information.
Contributor
Author
|
Looks like I don't have write access anymore @llucax ? 
|
github-project-automation
bot
moved this from Review approved
to Done
in Python SDK Roadmap
Contributor
Author
|
Oh, maybe only temporary. |
Contributor
Yeah, GitHub doing the 🦄 , I got the same in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are some unreachable battery inverters, their power values are tracked through fallback meters, and if there's any power flowing through these inverters, it is excluded from the power to be set on the working inverters.