Open
Conversation
frgnca
reviewed
Jan 28, 2023
| #Remove non-playback devices from audioDevicesList | ||
| for ( $index = 0; $index -lt $audioDevicesList.count; $index++ ) { | ||
| if ($audioDevicesList[$index].type -ne "Playback") { | ||
| $audioDevicesList.Remove($audioDevicesList[$index]) |
Owner
There was a problem hiding this comment.
Changing the number of item in an array while iterating through it this way using a for can end up not producing the desired result. I would instead suggest something like
Get-AudioDevice -List | Where-Object -Property Type -EQ "Playback"
frgnca
reviewed
Jan 28, 2023
| #Loop through audioDevicesList | ||
| for ( $index = 0; $index -lt $audioDevicesList.count; $index++ ) { | ||
| #Find the position of the default audio device | ||
| if ( $audioDevicesList[$index].name -eq $defaultPlaybackDevice.name) { |
Owner
There was a problem hiding this comment.
The fact that different devices can have the same name can cause this line to not work as it should. I would suggest something like replacing .name by .ID
Owner
|
I like the idea of adding more example scripts. I opened some conversations to resolve in the code. Since this script cycle through Playback devices specifically , I would also suggest adding that to the filename. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another example on how to use AudioDeviceCmdlets
This one cycles through the list of all audio devices, that way it works out of the box without having to specify the IDs of the devices you want to toggle.