Update jsdom to version 11.0.0 🚀 #425
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
jsdom just published its new version 11.0.0.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of jsdom.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 151 commits .
0f4128dVersion 11.0.0be65539Fix event handler property generation to properly rely on runScripts38c430fFactor out runScripts option testsecf7449Do not submit disconnected form elements5f3cbd6Properly implement event handler properties/attributes3eb19e7Remove a few more now-redundant toString()sb1b7f23Refactor XHR's send() implementation7d950c4Delete keygen from default stylesheet5151546Remove other unsupported CSS features from the default stylesheetdfc9430Delete webkit prefixes and other internal selectors in default CSS56fbd0dSupport ArrayBufferViews in xhr.send()ce13678Disable yet another flaky-on-CI XHR testdabf1a4Remove createCDATASection from benchmarks2d257efUpdate benchmark runner to support the new API1833f78Use Set instead of Array for HTMLCollection keysThere are 151 commits in total. See the full diff.