refactor: Remove unused NewNilSigner and NewNilRSASigner functions#13
Merged
frostyardyeti[bot] merged 1 commit intomainfrom Mar 27, 2026
Merged
refactor: Remove unused NewNilSigner and NewNilRSASigner functions#13frostyardyeti[bot] merged 1 commit intomainfrom
frostyardyeti[bot] merged 1 commit intomainfrom
Conversation
Both functions return nil which doesn't implement the interface, making them actively misleading. The codebase already handles nil signers via nil checks throughout generators. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bketelsen
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
NewNilSigner()ininternal/signer/gpg.go:261-264andNewNilRSASigner()ininternal/signer/rsa.go:125-128are exported functions that are never called anywhere in the codebase. They returnnilwhich doesn't implement the interface (calling any method on the returned value would panic), making them actively misleading. The codebase already handles nil signers via nil checks (e.g.,if g.signer != nilthroughout generators). Remove both functions.Automated improvement by yeti improvement-identifier