refactor: Use ShouldCopyPackage in Homebrew generator to skip redundant copies#16
Merged
frostyardyeti[bot] merged 1 commit intomainfrom Mar 27, 2026
Merged
Conversation
…opies The Homebrew generator unconditionally copied bottle files even when the destination already contained identical files. Use the same ShouldCopyPackage check that all other generators use to avoid redundant I/O during incremental regeneration. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bketelsen
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Homebrew generator in
internal/generator/homebrew/generator.go:59-76always copies bottle files unconditionally usingutils.CopyFile(). All other generators (deb, rpm, apk, pacman, sysext) useutils.ShouldCopyPackage()to check whether the file actually needs copying (same path, same size, same checksum). This means Homebrew regeneration always performs redundant I/O even when bottles haven't changed, which is especially wasteful in incremental mode or when the output directory already contains the bottles.Automated improvement by yeti improvement-identifier