refactor: Sort sysext SHA256SUMS entries for deterministic output#21
Open
frostyardyeti[bot] wants to merge 1 commit intomainfrom
Open
refactor: Sort sysext SHA256SUMS entries for deterministic output#21frostyardyeti[bot] wants to merge 1 commit intomainfrom
frostyardyeti[bot] wants to merge 1 commit intomainfrom
Conversation
The SHA256SUMS content was built by iterating over a Go map, whose iteration order is non-deterministic. Sort the lines before joining to ensure reproducible output across runs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
internal/generator/sysext/generator.golines 121-125, the SHA256SUMS content is built by iterating over a Go map (sha256Entries), whose iteration order is non-deterministic. This means the SHA256SUMS file will have entries in a different order on each run, even when the input is identical. This breaks reproducible builds and causes unnecessary diffs when checking generated output into version control or comparing incremental updates.Fix: Add
sort.Strings(sha256Lines)before thestrings.Joinon line 129. Thesortpackage is already imported in this file.Automated improvement by yeti improvement-identifier