refactor: Return error for unknown hash types in CalculateChecksum#22
Open
frostyardyeti[bot] wants to merge 1 commit intomainfrom
Open
refactor: Return error for unknown hash types in CalculateChecksum#22frostyardyeti[bot] wants to merge 1 commit intomainfrom
frostyardyeti[bot] wants to merge 1 commit intomainfrom
Conversation
Replace the default SHA256 fallback with an error return when an unsupported hash type is passed. This prevents silent misuse where a typo or incorrect hash type would produce a valid SHA256 checksum without any indication that the requested algorithm wasn't used. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
internal/utils/checksum.golines 73-74, theCalculateChecksumfunction silently defaults to SHA256 when given an unknownhashTypestring. This could mask bugs where a caller passes an incorrect hash type (e.g., a typo like"sha25"or"SHA256"with wrong casing). The function would return a valid SHA256 checksum without any indication that the requested algorithm wasn't used.Fix: Replace the
defaultcase withreturn "", fmt.Errorf("unsupported hash type: %s", hashType). All current callers pass known hash types ("sha256","sha1","md5"), so this change won't break anything but will catch future misuse.Automated improvement by yeti improvement-identifier