Skip to content

Change String::toLines to use ValueOption instead of Option #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Numpsy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change String::toLines to use ValueOption instead of Option #852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/FSharpLint.Core/Framework/Utilities.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,25 +150,25 @@ module String =
open System.IO

[<TailCall>]
let rec private iterateLines (lines: ResizeArray<string*int*bool>) (readLine: unit -> Option<string>) currentLine index =
let rec private iterateLines (lines: ResizeArray<string*int*bool>) (readLine: unit -> ValueOption<string>) currentLine index =
match currentLine with
| Some line ->
| ValueSome line ->
let nextLine = readLine ()
let isLastLine = Option.isNone nextLine
let isLastLine = ValueOption.isNone nextLine

lines.Add(line, index, isLastLine)

iterateLines lines readLine nextLine (index + 1)
| None -> ()
| ValueNone -> ()

let toLines input =
let lines = ResizeArray()
use reader = new StringReader(input)

let readLine () =
match reader.ReadLine() with
| null -> None
| line -> Some line
| null -> ValueNone
| line -> ValueSome line

iterateLines lines readLine (readLine ()) 0

Expand Down
Loading