-
Notifications
You must be signed in to change notification settings - Fork 79
Seq extensions: add trySkip #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@gdziadkiewicz hey do you mind helping me upgrade paket (and paket deps) from v6 to v8? I'm not a paket expert, I just replaced |
|
Hi @knocte , no problem, I will take a look tomorrow morning :) |
|
Lovely thanks; sounds good, I'll rebase as soon as 224 lands. |
|
@knocte I'm working on making the Fable tests work after my changes, sorry for the wait |
|
@knocte merged the other PR |
This way it is an alternative to Seq.skip: same but non-partial function (that doesn't throw exceptions), following same approach as tryHeadTail[1]. [1] fdbeaf2
This way the compiler will make sure that this recursive function will not cause stackoverflows.
|
@gdziadkiewicz hey, thanks! Rebased. Now, it seems CI is failing because, even though your PR upgraded general things to .NET8.x(&F#v8.x), FSharp.Core seems to be still locked to 4.x. How can I upgrade FSharp.Core to v8.x? I assume that I gotta change manually the version in Thanks. (BTW the PR can already be reviewed in case you have feedback, and I will address it too next time I update the PR, cheers.) |
Mmm, changing manually both files seemed to work. If this is ok lmk and I'll squash latest commit to get this ready to be merged. |
This way it is an alternative to Seq.skip: same but
non-partial function (that doesn't throw exceptions),
following same approach as tryHeadTail[1].
[1] fdbeaf2