Added initial support for a P8 (Pico-8) dialect#87
Draft
whizzter wants to merge 1 commit intofstirlitz:masterfrom
Draft
Added initial support for a P8 (Pico-8) dialect#87whizzter wants to merge 1 commit intofstirlitz:masterfrom
whizzter wants to merge 1 commit intofstirlitz:masterfrom
Conversation
- compound assignments - != alias for ~=
Owner
|
Not rejecting yet, but I am definitely not going to merge this as-is.
* other than in portability code |
Author
Well there's PicoLove that's an opensource impl for porting and I'm using this for a small experiment runtime (No idea how useful it'll end up but more open support wouldn't hurt?)
Agreed, already ran into more missing features so i could def re-submit later if you'd prefer that.
Not yet, will verify.
Yeah didn't notice the existence of these 2 before submitting and noticing the CI run. |
24840d1 to
5015784
Compare
DollarNoob
added a commit
to DollarNoob/Synapsploit
that referenced
this pull request
Oct 19, 2024
fstirlitz/luaparse#87 += -= *= /= //= %= ^= ..=
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes so far are the addition of a new P8 dialect with bitwise operators, compound assignments and a != alias for ~=
There are a also some other shorthands for the P8 dialect listed on https://www.lexaloffle.com/pico-8.php?page=manual but I didn't run into issues with those yet in my project and didn't have time yet to check how to modify the parser (I'll probably run into those later on though but could be good to have the initial parts upstreamed?)