Fix flaky metrics e2e test by adding curl retries#115
Merged
creydr merged 1 commit intofunctions-dev:mainfrom Apr 29, 2026
Merged
Fix flaky metrics e2e test by adding curl retries#115creydr merged 1 commit intofunctions-dev:mainfrom
creydr merged 1 commit intofunctions-dev:mainfrom
Conversation
The curl-metrics pod runs a single curl invocation. If the metrics endpoint is transiently unavailable when the pod starts, curl exits with a connection refused error and the pod enters Failed status, causing the test to time out. Add --retry, --retry-delay, and --retry-connrefused flags so curl retries on transient connection failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
curl-metricspod in the metrics e2e test runs a singlecurlinvocation. If the metrics endpoint is transiently unavailable when the pod starts (e.g. due to scheduling/startup timing), curl exits with "connection refused", the pod entersFailedstatus, and the test times out waiting forSucceeded.--retry 10 --retry-delay 5 --retry-connrefusedflags so curl retries on transient connection failures instead of failing immediately.