stop auto-computing area#208
Open
TeunHuijben wants to merge 1 commit intomainfrom
Open
Conversation
Collaborator
Author
|
@cmalinmayor, does this answer your original comment:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 93.35% 93.35%
=======================================
Files 59 59
Lines 3249 3250 +1
=======================================
+ Hits 3033 3034 +1
Misses 216 216 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem: The original code auto-computed
areafrom scratch onTracksinitialization (if it wasn't already on the graph nodes). Commenting out thecore_computed_features.append("area")line entirely broke the case whereareawas already on the graph — it would no longer be registered intracks.featuresor activated in the annotator.The fix: Replace the single list with a list of
(key, compute_if_missing)tuples.areagetscompute_if_missing=False, meaning:areais already on the graph → activated and added totracks.features(backward compat for files that have area)areais not on the graph → skipped; caller must useenable_features(["area"])explicitlyCloses #193