release: prepare v1.3.1#78
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR introduces an ergonomic one-call startup API for ChangesErgonomic Startup API
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 26: The README currently states "v1.3.1" as the current and latest
release; change that sentence (the line containing "SwiftASB is actively
maintained..." and the literal "v1.3.1") to avoid asserting the tag is
published—e.g., say the API is v1 and that "v1.3.1 is the intended/upcoming
release" or "latest release (v1.3.1) pending publication" and only merge the
definitive "latest" phrasing after the tag is actually published.
In `@Sources/SwiftASB/SwiftASB.docc/GettingStartedWithSwiftASB.md`:
- Around line 56-57: Update the wording to clarify ownership of compatibility
policy: state that compatibility policy is configured on the StartupRequest
passed to CodexAppServer/start(_:) (not via initialize(_:)), and that the
lower-level start() + initialize(_:) path is useful when the client
intentionally owns each startup step (custom compatibility policy provided via
StartupRequest, diagnostics-only startup screens, or tests that inspect the
selected binary before deciding whether to initialize). Refer to
CodexAppServer/start(_:) and CodexAppServer/initialize(_:) and the
StartupRequest type in the revised sentence.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: fd68b831-8df1-42b8-9d96-04c7ce742803
📒 Files selected for processing (10)
README.mdROADMAP.mdSources/SwiftASB/Public/CodexAppServer+Bootstrap.swiftSources/SwiftASB/Public/CodexAppServer.swiftSources/SwiftASB/Public/CodexErrors.swiftSources/SwiftASB/SwiftASB.docc/CodexAppServer.mdSources/SwiftASB/SwiftASB.docc/GettingStartedWithSwiftASB.mdTests/SwiftASBTests/Public/CodexAppServerTestSupport.swiftTests/SwiftASBTests/Public/CodexAppServerTests.swiftdocs/maintainers/v1-public-api-audit.md
| ### Status | ||
|
|
||
| SwiftASB is actively maintained and supported by Gale. Our current API is v1, and `v1.3.0` is the current and latest release. | ||
| SwiftASB is actively maintained and supported by Gale. Our current API is v1, and `v1.3.1` is the current and latest release. |
There was a problem hiding this comment.
Avoid presenting v1.3.1 as already released before the tag is published.
These lines can briefly break user onboarding if the tag isn’t live yet (install command fails and “latest release” is inaccurate). Consider wording this as pending until publication, or merge this text only once the tag/release is public.
Suggested wording tweak
-SwiftASB is actively maintained and supported by Gale. Our current API is v1, and `v1.3.1` is the current and latest release.
+SwiftASB is actively maintained and supported by Gale. Our current API is v1.
+The next release is `v1.3.1` (update this line to “latest release” once published).-.package(url: "https://github.com/gaelic-ghost/SwiftASB", from: "1.3.1"),
+.package(url: "https://github.com/gaelic-ghost/SwiftASB", from: "1.3.1"), // after v1.3.1 is publishedAs per coding guidelines, README.md: "Keep the README product-facing and approachable for package users and their agents".
Also applies to: 41-41
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@README.md` at line 26, The README currently states "v1.3.1" as the current
and latest release; change that sentence (the line containing "SwiftASB is
actively maintained..." and the literal "v1.3.1") to avoid asserting the tag is
published—e.g., say the API is v1 and that "v1.3.1 is the intended/upcoming
release" or "latest release (v1.3.1) pending publication" and only merge the
definitive "latest" phrasing after the tag is actually published.
Release
startup/ergonomic-startup-errorsmainupdates behind pull request review and CIv1.3.1was created locally before this PR so the reviewed release candidate is preserved exactlyReview Loop
Before merge,
scripts/repo-maintenance/release.shwatches CI and stops on review comments unless the maintainer has already addressed or resolved them and reruns with--review-comments-addressed.