fix: pass the actual value, not the function

[Arukuen]

fixes #8

Summary by CodeRabbit

• Refactor
  • Optimized CSS property value handling to reduce unnecessary processing and improve performance.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

A bug fix that removes unnecessary function call wrappers around CSS property values in the cssRule action-type handler. The change updates CSS.supports checks to use direct value strings instead of computed function results.

Changes

Cohort / File(s)	Summary
CSS Rule Bug Fix src/action-types/frontend/cssRule.js	Removed function call wrappers (value()) and replaced with direct string values for CSS property checks, eliminating redundant function invocations in CSS.supports validation

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A hop through CSS rules so fine,
Where functions were tangled, now streamlined,
No more wrapper calls to delay,
Direct values hop the right way,
CSS.supports now runs with delight! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: replacing a function wrapper with the actual value in the CSS rule action, directly addressing the fix objective.
Linked Issues check	✅ Passed	The PR addresses issue #8 by fixing the CSS rule action editor error through passing the actual value instead of a function reference, resolving the stated objective.
Out of Scope Changes check	✅ Passed	All changes are scoped to fixing the CSS rule action value handling in cssRule.js, directly addressing the linked issue without introducing unrelated modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a002e7 and bdf5566.

📒 Files selected for processing (1)

• src/action-types/frontend/cssRule.js

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build

🔇 Additional comments (1)

src/action-types/frontend/cssRule.js (1)

8-13: LGTM! Correct fix for the CSS rule validation.

The bug was caused by passing a function reference to CSS.supports() instead of the resolved string value. Now value is properly evaluated before being used in the validation check, ensuring CSS.supports() receives the expected string arguments.

The dynamic value recalculation is still handled correctly via the onBegin: self => self.refresh() callback at line 17.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🤖 Pull request artifacts

file	commit
pr12-interactions-12-merge.zip	bdf5566