-
Notifications
You must be signed in to change notification settings - Fork 3
Simulation model refactoring with refactoring of db_handler. #1310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schema validation bug fixes.
…tions Reference model corrections (new db simulation model)
This comment has been minimized.
This comment has been minimized.
Set trigger current limit to 20 uA
Correct branch to main for simulation model upload
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Improve testing of results and allow comparision of lists of floats in json/yaml files
This comment has been minimized.
This comment has been minimized.
Add schema for fake mirror list
This comment has been minimized.
This comment has been minimized.
Remove sandboxes
Analysis Details0 IssuesCoverage and DuplicationsProject ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a significant update to allow simtools with the improved and simplified structure of the simulation model.
CTAO-Simulation-ModelParameters-LATEST, which is a copy of the new repository simulation-models (check branch v1.0.0-parameters)parameter_versionandmodel_version(required a lot of small changes; especially when initializing the configurator, 'model_version' needs now to be specified)model_versionall relevant parameters and their versionsMany code changes, but also significant simplifications.
Open points:
v1.0.0-parameters.