Skip to content

Conversation

@GernotMaier
Copy link
Contributor

@GernotMaier GernotMaier commented Jan 17, 2025

This is a significant update to allow simtools with the improved and simplified structure of the simulation model.

  • model parameters are stored in a new database called CTAO-Simulation-ModelParameters-LATEST, which is a copy of the new repository simulation-models (check branch v1.0.0-parameters)
  • introduction of difference between parameter_version and model_version (required a lot of small changes; especially when initializing the configurator, 'model_version' needs now to be specified)
  • introduction of production tables, which list for a given model_version all relevant parameters and their versions
  • removes reading / access to 'derived' DB parameters (these parameters are now in the model parameter DB).

Many code changes, but also significant simplifications.

Open points:

@ctao-dpps-sonarqube

This comment has been minimized.

@ctao-dpps-sonarqube

This comment has been minimized.

1 similar comment
@ctao-dpps-sonarqube

This comment has been minimized.

@ctao-dpps-sonarqube

This comment has been minimized.

@ctao-dpps-sonarqube

This comment has been minimized.

@ctao-dpps-sonarqube
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 99.10% Coverage (93.30% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

@GernotMaier GernotMaier merged commit 096a270 into main Jan 31, 2025
14 checks passed
@GernotMaier GernotMaier deleted the db-simulation-model-refactoring branch January 31, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review and replace derived value DB

3 participants