Skip to content

GAP packages with configure support must support --with-gaproot=PATH #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fingolfin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GAP packages with configure support must support --with-gaproot=PATH #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ All of the following inputs are optional.

### What's new in v3

- Dropped support for GAP packages that have a `configure` script which does not
support the `--with-gaproot=PATH` argument.
- The inputs `build-needed-pkgs`, `build-suggested-pkgs` and `build-extensions` were
added. Setting these to `true` will also compile the relevant dependencies, and setting
them to `recursive` will also compile the dependencies' dependencies, etc.
Expand Down
6 changes: 1 addition & 5 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,8 @@ runs:
if [[ -x autogen.sh ]]; then
./autogen.sh
fi
if grep Autoconf ./configure > /dev/null
then
if [[ -x configure ]]; then
./configure --with-gaproot=$GAPROOT ${{ inputs.CONFIGFLAGS }}
make -j4 V=1
elif [[ -x configure ]]; then
./configure ${{ inputs.CONFIGFLAGS }} $GAPROOT
make -j4 CFLAGS="$CFLAGS" CXXFLAGS="$CXXFLAGS" LDFLAGS="$LDFLAGS"
fi

Expand Down