Conversation
|
Weird thing I noticed: the |
|
@stertooy Isn't it like DVI file contains timestamp in a comment? |
|
@limakzi It's very likely that a creation date timestamp somewhere in the This doesn't happen in the PDF's because the |
| description: "Body text for the new GitHub release that will appear on the package's GitHub Releases page" | ||
| required: false | ||
| default: "Release of ${{ github.event.repository.name }}" | ||
| affix: |
There was a problem hiding this comment.
@stertooy I think we could replace affix with two different timestamps, for example?
There was a problem hiding this comment.
The idea is not to have any affix at all for end users, to keep things as simple as possible.
| if: ${{ inputs.dry-run == 'true' }} | ||
| shell: bash | ||
| run: echo "${{ inputs.body-text }}" > $RUNNER_TEMP/Release_text_for_${PKGNAME}_${VERSION}.md | ||
| run: echo "${{ inputs.body-text }}" > $RUNNER_TEMP/Release_text_for_${PKGNAME}_${VERSION}${{ inputs.affix }}.md |
There was a problem hiding this comment.
@stertooy Why not?
| run: echo "${{ inputs.body-text }}" > $RUNNER_TEMP/Release_text_for_${PKGNAME}_${VERSION}${{ inputs.affix }}.md | |
| run: echo "${{ inputs.body-text }}" > $RUNNER_TEMP/Release_text_for_${PKGNAME}_${VERSION}_${{ inputs.affix }}.md |
There was a problem hiding this comment.
Again, this is because the affix input is expected to be empty, except during the CI tests in this repo. The CI script will put either "-1" or "-2" in the affix input, so an extra underscore isn't needed I think.
As suggested in #50.
The three supported formats,
.tar.gz,.tar.bz2and.zipshould now always be reproducible archives. This is also tested by running this action twice, and then comparing thesha256checksums of both archives.Unfortunately, I had to add an extra input to be able to properly test this. I recommend leaving it undocumented, since it server no purpose for end users.
I've set
SOURCE_DATE_EPOCHto the package release date as specified inPackageInfo.g.