Skip to content

Loosen @Date handling, do not require specific format#332

Merged
fingolfin merged 1 commit intomasterfrom
codex/Date
Mar 8, 2026
Merged

Loosen @Date handling, do not require specific format#332
fingolfin merged 1 commit intomasterfrom
codex/Date

Conversation

@fingolfin
Copy link
Member

Co-authored-by: Codex codex@openai.com

@codecov
Copy link

codecov bot commented Mar 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.98%. Comparing base (2680c77) to head (6665a85).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   90.92%   90.98%   +0.06%     
==========================================
  Files          13       13              
  Lines        2523     2529       +6     
==========================================
+ Hits         2294     2301       +7     
+ Misses        229      228       -1     
Files with missing lines Coverage Δ
gap/AutoDocMainFunction.gi 86.77% <100.00%> (+0.27%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Codex <codex@openai.com>
@fingolfin
Copy link
Member Author

@mohamed-barakat that resolve the @Date problem. Next I run into an error caused by GAPDoc not liking something in the .bib file. I had to edit

@Misc{homalg-project,
author = {The~homalg~project~authors, \phantom{.}},

by removing , \phantom{.}.

Then it runs through but with a ton of warnings and LaTeX errors, I am working on a fix for this right now, stay tuned.

@fingolfin fingolfin enabled auto-merge (squash) March 8, 2026 15:39
@fingolfin fingolfin merged commit d89ad60 into master Mar 8, 2026
8 checks passed
@fingolfin fingolfin deleted the codex/Date branch March 8, 2026 15:41
@mohamed-barakat
Copy link
Contributor

Thank you very much Max.

makedoc.g still includes a maketest entry. If I understand correctly,AutoDoc does not create maketest.g anymore. So I still need to reactivate the tests manually.

@fingolfin
Copy link
Member Author

Try using extract_examples

@mohamed-barakat
Copy link
Contributor

Try using extract_examples

Setting extract_examples := true didn't produce the tests. I have to properly read the manual of AutoDoc and update the makedoc.g accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants