Remove d suffix from min-release-age in .npmrc#961
Remove d suffix from min-release-age in .npmrc#961marc1404 wants to merge 1 commit intogardener:masterfrom
Conversation
✅ Deploy Preview for gardener-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughThis PR modifies ChangesNPM Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.npmrc:
- Line 1: The .npmrc contains an invalid value for min-release-age
("min-release-age=7d"); update the entry to "min-release-age=7" (remove the "d")
in the .npmrc file and amend the commit so its message accurately reflects the
change (e.g., "Remove d suffix from min-release-age" or similar) to match the
actual fix for min-release-age.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
6deb577 to
a58a3a6
Compare
VelmiraS
left a comment
There was a problem hiding this comment.
The 7d suffix isn't valid npm 11 syntax — min-release-age expects a plain integer (number of days). Changing it to min-release-age=7 is the correct fix. The supply chain protection intent is fully preserved. With npm 10 this setting was ignored
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
npmfails for me:I'm using
npm@v11which should supportmin-release-age:However, it seems to assume days as the unit, so it rejects the
dsuffix.I am unable to find any documentation with
npmfor this, but it works for me 🤷♂️Which issue(s) this PR fixes:
n.a.
Special notes for your reviewer:
/cc @klocke-io
Summary by CodeRabbit