Skip to content

Remove d suffix from min-release-age in .npmrc#961

Open
marc1404 wants to merge 1 commit intogardener:masterfrom
marc1404:chore/npm-min-release-age
Open

Remove d suffix from min-release-age in .npmrc#961
marc1404 wants to merge 1 commit intogardener:masterfrom
marc1404:chore/npm-min-release-age

Conversation

@marc1404
Copy link
Copy Markdown
Member

@marc1404 marc1404 commented May 8, 2026

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

npm fails for me:

make dev       
npx vitepress dev
npm warn invalid config before=null set in ~/documentation/.npmrc
npm warn invalid config Must be one of: null, valid Date string
npm error Invalid time value
npm error A complete log of this run can be found in: ~/.npm/_logs/2026-05-08T07_46_01_143Z-debug-0.log
make: *** [dev] Error 1

I'm using npm@v11 which should support min-release-age:

npm --version
11.12.1

However, it seems to assume days as the unit, so it rejects the d suffix.
I am unable to find any documentation with npm for this, but it works for me 🤷‍♂️

Which issue(s) this PR fixes:

n.a.

Special notes for your reviewer:

/cc @klocke-io

Summary by CodeRabbit

  • Chores
    • Minor configuration file update with no user-facing impact.

@marc1404 marc1404 requested a review from a team as a code owner May 8, 2026 07:48
@gardener-prow gardener-prow Bot requested a review from klocke-io May 8, 2026 07:48
@gardener-prow gardener-prow Bot added the kind/enhancement Enhancement, improvement, extension label May 8, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 8, 2026

Deploy Preview for gardener-docs ready!

Name Link
🔨 Latest commit a58a3a6
🔍 Latest deploy log https://app.netlify.com/projects/gardener-docs/deploys/69fd961ad44a7e00086284d9
😎 Deploy Preview https://deploy-preview-961--gardener-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented May 8, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign marc1404 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow Bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels May 8, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 8, 2026

Review Change Stack

Warning

Rate limit exceeded

@marc1404 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 56 minutes and 47 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: e18a19b2-77d7-49bc-b72b-3f8b1445cd4e

📥 Commits

Reviewing files that changed from the base of the PR and between 6deb577 and a58a3a6.

📒 Files selected for processing (1)
  • .npmrc
📝 Walkthrough

Walkthrough

This PR modifies .npmrc by reconfirming the min-release-age=7d setting. The change produces a +1/-1 line diff but introduces no functional alteration to the NPM release configuration.

Changes

NPM Configuration

Layer / File(s) Summary
Configuration
.npmrc
The min-release-age setting remains 7d with no semantic change.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Poem

One line touched, one line reborn,
No change at all, yet here we mourn.
A rabbit hops through .npmrc today—
Seven days young, hip-hip-hooray! 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove d suffix from min-release-age in .npmrc' accurately summarizes the main change in the pull request.
Description check ✅ Passed The pull request description provides complete information including categorization (/kind enhancement), explanation of the issue with npm errors, the reason for the fix, npm version context, and reviewer notes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gardener-prow gardener-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 8, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.npmrc:
- Line 1: The .npmrc contains an invalid value for min-release-age
("min-release-age=7d"); update the entry to "min-release-age=7" (remove the "d")
in the .npmrc file and amend the commit so its message accurately reflects the
change (e.g., "Remove d suffix from min-release-age" or similar) to match the
actual fix for min-release-age.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 55eae427-95d8-4924-aef6-ce7dc346b002

📥 Commits

Reviewing files that changed from the base of the PR and between 131d0e1 and 6deb577.

📒 Files selected for processing (1)
  • .npmrc

Comment thread .npmrc Outdated
@marc1404 marc1404 force-pushed the chore/npm-min-release-age branch from 6deb577 to a58a3a6 Compare May 8, 2026 07:51
Copy link
Copy Markdown
Collaborator

@VelmiraS VelmiraS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 7d suffix isn't valid npm 11 syntax — min-release-age expects a plain integer (number of days). Changing it to min-release-age=7 is the correct fix. The supply chain protection intent is fully preserved. With npm 10 this setting was ignored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants