v1.33.3.0 fix: replace bash brace groups with subshells in build script for Windows compatibility#1460
Open
realcarsonterry wants to merge 2 commits into
Open
Conversation
…dows compatibility Fixes garrytan#1457 On Windows with Git Bash + Bun, the build script fails because Bun's Windows shell parser doesn't support bash brace groups { cmd; }. Changed three occurrences of: { git rev-parse HEAD 2>/dev/null || true; } > path/.version To POSIX-compliant subshells: ( git rev-parse HEAD 2>/dev/null || true ) > path/.version Subshells are universally supported and functionally equivalent for one-shot stdout redirection. This allows bun run build to succeed on Windows without affecting Unix behavior.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
realcarsonterry
changed the title
Contributor
Author
Needs InvestigationStatus: Build-image step failing (infrastructure issue). The 'Sync PR title to VERSION' check also failed initially but may have been retriggered. Impact: Fixes issue #1457 - Allows Windows users to run Next step: The build-image failure appears to be a Docker registry permission issue, not related to the code changes. May need maintainer intervention or a workflow retrigger. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1457
Summary
On Windows with Git Bash + Bun,
bun run buildfails because Bun's Windows shell parser doesn't support bash brace groups{ cmd; }.Changes
Changed three occurrences in
package.jsonline 12 from:{ git rev-parse HEAD 2>/dev/null || true; } > path/.versionTo POSIX-compliant subshells:
Why This Works
( ... )are universally supported in POSIX bash, zsh, and Bun's Windows shellbun run buildTesting
Tested on Windows 11 with Git Bash + Bun 1.3.13 - build now completes successfully.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmithwith what you need.