v1.33.3.0 fix: update documentation to use artifacts_sync_mode instead of deprecated gbrain_sync_mode#1461
Open
realcarsonterry wants to merge 2 commits into
Conversation
…cated gbrain_sync_mode Fixes garrytan#1441 The config key was renamed from gbrain_sync_mode to artifacts_sync_mode in a previous release, but the documentation still referenced the old key. Updated all occurrences in: - docs/gbrain-sync.md - docs/gbrain-sync-errors.md This ensures users following the documentation will set the correct config key that gstack-brain-sync actually reads.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
realcarsonterry
changed the title
Contributor
Author
Needs Minor FixStatus: 17/18 tests passing. One fixable issue: 'Sync PR title to VERSION' check failing. Impact: Fixes issue #1441 - Updates documentation to use correct config key Next step: Need to verify VERSION file matches PR title format. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1441
Summary
The config key was renamed from
gbrain_sync_modetoartifacts_sync_modein a previous release, but the documentation still referenced the old key. This caused confusion for users following the docs, as they would set a config key thatgstack-brain-syncdoesn't actually read.Changes
Updated all occurrences of the deprecated key in:
docs/gbrain-sync.md(3 occurrences)docs/gbrain-sync-errors.md(2 occurrences)Changed:
gstack-config set gbrain_sync_mode→gstack-config set artifacts_sync_modegstack-config get gbrain_sync_mode→gstack-config get artifacts_sync_modegbrain_sync_mode_prompted→artifacts_sync_mode_promptedImpact
Users following the documentation will now set the correct config key that
gstack-brain-syncactually reads, ensuring brain sync federation works as expected.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmithwith what you need.