v1.33.3.0 fix: use file copies instead of symlinks on Windows for skill installation#1462
Open
realcarsonterry wants to merge 2 commits into
Open
v1.33.3.0 fix: use file copies instead of symlinks on Windows for skill installation#1462realcarsonterry wants to merge 2 commits into
realcarsonterry wants to merge 2 commits into
Conversation
…ation Fixes garrytan#1456 On Windows (MSYS2/Git Bash, MINGW64), `ln -snf` silently creates file copies instead of symlinks when Developer Mode is disabled. This causes skill files to become stale after `git pull` since the "symlinks" are actually frozen copies. Changes: - Detect Windows platform and use `cp -f` instead of `ln -snf` for SKILL.md files in link_claude_skill_dirs() - Add informational note on Windows installs reminding users to re-run ./setup after git pull to refresh skill files - Preserves symlink behavior on Unix-like systems This follows the same pattern used in commit 999987ef for node_modules cache handling. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
999d9a7 to
d648768
Compare
Contributor
Author
Ready to Merge ✓All 18 test checks passing. Only the infrastructure 'report' step failed (not a code issue). Impact: Fixes issue #1456 - Windows users currently have stale skill files after Testing: Follows the same pattern from commit 999987ef for node_modules cache handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1456
Summary
On Windows (MSYS2/Git Bash, MINGW64),
ln -snfsilently creates file copies instead of symlinks when Developer Mode is disabled. This causes skill files to become stale aftergit pullsince the "symlinks" are actually frozen copies that don't reflect upstream updates.Root Cause
The
setupscript'slink_claude_skill_dirs()function usedln -snfunconditionally at line 404, without checking theIS_WINDOWSflag that was already defined but only used in other parts of the script.Changes
cp -finstead ofln -snffor SKILL.md files inlink_claude_skill_dirs()Implementation
This follows the same pattern used in commit 999987ef for node_modules cache handling.
Impact
./setupaftergit pull🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmithwith what you need.