Skip to content

fix: plan mode exception for review log + telemetry writes (v0.9.0.1)#234

Merged
garrytan merged 6 commits intomainfrom
garrytan/plan-mode-disk-write
Mar 20, 2026
Merged

fix: plan mode exception for review log + telemetry writes (v0.9.0.1)#234
garrytan merged 6 commits intomainfrom
garrytan/plan-mode-disk-write

Conversation

@garrytan
Copy link
Owner

Summary

  • Review logs and telemetry now persist during plan mode. When running /plan-ceo-review, /plan-eng-review, or /plan-design-review in plan mode, the review result wasn't saved to disk — the dashboard showed stale or missing entries even though a review was just completed. Same issue affected telemetry logging at the end of every skill. Both now work reliably in plan mode.
  • Added explicit "PLAN MODE EXCEPTION — ALWAYS RUN" notes with reasoning chain (safety argument, preamble precedent, consequence of skipping) to:
    • Review Log sections in 3 plan review .tmpl files
    • Telemetry section in gen-skill-docs.ts (propagated to all 17+ skills)
  • Added test assertion for plan-mode exception in generated telemetry section

Test Coverage

  • 407 tests pass, 0 failures, 1854 assertions
  • New assertion: expect(content).toContain('PLAN MODE EXCEPTION') in telemetry epilogue test

Pre-Landing Review

No issues found.

Test plan

  • bun test passes (407 tests, 0 failures)
  • All SKILL.md files regenerated (Claude + Codex/agents)
  • Plan-mode exception note appears in all 17 Claude SKILL.md files (telemetry) and 3 plan review SKILL.md files (review log)
  • CEO + Eng review both CLEARED

🤖 Generated with Claude Code

garrytan and others added 6 commits March 19, 2026 22:03
Add explicit plan-mode exception notes to review log sections in all
3 plan review skill templates and the telemetry section in gen-skill-docs.ts.
When Claude runs in plan mode, it self-censors bash writes — but review
logging and telemetry write to ~/.gstack/ (user metadata, not project
files). The preamble already writes to the same directory successfully.
The exception note gives Claude a reasoning chain: safety argument,
precedent, and consequence of skipping.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Default opt-in is now "Help gstack get better!" (community mode with
stable device ID). If declined, offers anonymous mode as a softer
alternative before fully off.
@garrytan garrytan merged commit 91bea06 into main Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant