Skip to content

Add mode settings to hashed parameters #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joamatab merged 1 commit into from
Mar 10, 2026
Merged

Add mode settings to hashed parameters #683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions gplugins/gmeep/write_sparameters_meep.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,10 @@ def write_sparameters_meep(
if setting not in settings_get_simulation:
raise ValueError(f"{setting!r} not in {settings_get_simulation}")

port_names = [port.name for port in component.ports]
port_source_names = port_source_names or port_names
port_source_modes = port_source_modes or {key: [0] for key in port_source_names}
port_modes = port_modes or [0]
port_symmetries = port_symmetries or {}

xmargin_left = xmargin_left or xmargin
Expand All @@ -298,6 +302,9 @@ def write_sparameters_meep(
zmargin_bot = zmargin_bot or zmargin

sim_settings = dict(
port_source_names=port_source_names,
port_source_modes=port_source_modes,
port_modes=port_modes,
resolution=resolution,
port_symmetries=port_symmetries,
wavelength_start=wavelength_start,
Expand Down Expand Up @@ -349,14 +356,6 @@ def write_sparameters_meep(
right=xmargin_right,
)

dummy = Component()
component_ref = dummy << component
ports = component_ref.ports
port_names = [port.name for port in ports]
port_source_names = port_source_names or port_names
port_source_modes = port_source_modes or {key: [0] for key in port_source_names}
port_modes = port_modes or [0]

num_sims = len(port_source_names) - len(port_symmetries)

# set verbosity
Expand Down
Loading