Add configurable verbosity to mesh generator, fix tests, refactor palace simulation classes and local non-Apptainer Palace support#49
Open
benvial wants to merge 10 commits intogdsfactory:mainfrom
Open
Conversation
Add `verbosity` parameter to `generate_mesh()` function to control Gmsh output level instead of hardcoding it. Update failing tests and fix mesh result attribute access from `_mesh_result` to `_last_mesh_result`.
benvial
changed the title
benvial
changed the title
Member
Author
|
closes #41 |
Member
Author
|
TODO:
|
…line - Introduce EigenmodeConfig and eigenmode simulation type - Add absorbing_boundary flag for boundary condition control - Refactor mesh generation pipeline to support multiple simulation types - Update Palace config generation for driven/eigenmode/electrostatic simulations - Fix port excitation logic based on simulation type - Add coverage reporting to test command
dot-cross
reviewed
Mar 19, 2026
| model_name: str = "palace", | ||
| simulation_type: str = "driven", | ||
| driven_config: DrivenConfig | None = None, | ||
| eigenmode_config: EigenmodeConfig | None = None, |
Contributor
There was a problem hiding this comment.
Lets add the new arguments to the doc string
dot-cross
reviewed
Mar 19, 2026
| air_margin: Air box margin (um) | ||
| fmax: Max frequency for config (Hz) | ||
| show_gui: Show gmsh GUI during meshing | ||
| simulation_type: str = "driven", |
Contributor
There was a problem hiding this comment.
Add also the other new arguments to the doc string
Contributor
|
Looks good. I think we should include the number of computed field modes to save to disk to the eigenmode config on next commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR consolidates common simulation logic into a shared mixin and adds support for running Palace without Apptainer.
Key Features
PalaceSimMixinfor DrivenSim, EigenmodeSim, ElectrostaticSimrun_local(use_apptainer=False)runs Palace directly without Apptainer