fix commit calendar svg parsing for getting the highest number of commits#112
Open
xavierforge wants to merge 1 commit intogelstudios:mainfrom
Open
fix commit calendar svg parsing for getting the highest number of commits#112xavierforge wants to merge 1 commit intogelstudios:mainfrom
xavierforge wants to merge 1 commit intogelstudios:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current script is unable to capture the highest number of commits.
GitHub changed the contribution calendar SVG format again after pull request #106
Fortunately, the pattern
$(NUMBER OF COMMIT) contributions on $(DATE)stays the same and seems unlikely to change further.So, this pull request uses regex to get the number of commits in the function
parse_contributions_calendar.Now, it can get the highest number of commits instead of 0 and generate an excellent calendar visual.