Skip to content

Conversation

@DRadmir
Copy link
Contributor

@DRadmir DRadmir commented Dec 5, 2025

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @DRadmir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates initial support for The Open Network (TON) into the existing WalletConnect infrastructure. It expands the system's ability to handle TON-specific transactions by introducing new data types, extending transaction processing logic, and defining new WalletConnect methods. The core mechanism for signing TON data has been implemented, although specific message signing functionality is noted as a future enhancement.

Highlights

  • TON Transaction Support: The WalletConnectorSigner has been updated to recognize and process TON (The Open Network) transactions, extending its capabilities beyond Solana and Sui.
  • TON Data Structures and Mapping: New data structures, specifically WCTonMessage, have been introduced to handle TON-specific message components. Additionally, mapping logic has been added to integrate WalletConnectTransaction.ton with WalletConnectorTransaction.ton.
  • New WalletConnect Methods for TON: The WalletConnectionMethods enum now includes ton_sendMessage and ton_signData, indicating the intent to support these operations for TON.
  • TON Data Signing Implementation: A signData function has been implemented within TonSigner. This function is responsible for decoding TON messages and converting them into a format suitable for signing, laying the groundwork for secure TON transaction handling.
  • Partial ton_signData Support: While the ton_signData method is recognized, its full implementation in the SignMessageSceneViewModel is currently a placeholder and explicitly throws an error, indicating it's not yet fully supported.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for TON WalletConnect by updating various enums, structs, and transaction handling logic. The changes are generally in the right direction. However, I've found a couple of critical issues. One is a syntax error in a switch statement that will prevent compilation. The other is in the TonSigner, where unsafe BigInt initialization could lead to a crash, a type mismatch would cause a compilation error, and part of the message data (stateInit) is being ignored. I've provided suggestions to fix these issues to ensure the code is correct and robust.

@DRadmir DRadmir force-pushed the 1388-add-ton-walletconnect-support branch from 5d115ed to 108c08c Compare December 5, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants