-
Notifications
You must be signed in to change notification settings - Fork 56
Add TON WalletConnect support #1470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @DRadmir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates initial support for The Open Network (TON) into the existing WalletConnect infrastructure. It expands the system's ability to handle TON-specific transactions by introducing new data types, extending transaction processing logic, and defining new WalletConnect methods. The core mechanism for signing TON data has been implemented, although specific message signing functionality is noted as a future enhancement. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for TON WalletConnect by updating various enums, structs, and transaction handling logic. The changes are generally in the right direction. However, I've found a couple of critical issues. One is a syntax error in a switch statement that will prevent compilation. The other is in the TonSigner, where unsafe BigInt initialization could lead to a crash, a type mismatch would cause a compilation error, and part of the message data (stateInit) is being ignored. I've provided suggestions to fix these issues to ensure the code is correct and robust.
...ChainServices/WalletConnectorService/Extensions/WalletConnectTransaction+ChainServices.swift
Show resolved
Hide resolved
5d115ed to
108c08c
Compare
No description provided.