feat: enable auto-approve, initial prompt, and issue linking for Amp agent#798
Merged
arnestrickmann merged 1 commit intogeneralaction:mainfrom Feb 10, 2026
Merged
Conversation
|
@Klohto is attempting to deploy a commit to the General Action Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
Sharing initial prompt https://ampcode.com/threads/T-019c429a-9f66-756e-8620-cb6124480097 |
Contributor
Greptile OverviewGreptile SummaryThis PR enables advanced task options for the Amp agent by adding missing
The changes follow existing patterns used by other providers (Claude, Codex, Cursor, etc.) and integrate seamlessly with the existing PTY manager logic in Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| src/shared/providers/registry.ts | Added autoApproveFlag and initialPromptFlag to Amp provider configuration - enables auto-approve and initial prompt features |
| src/renderer/lib/agentConfig.ts | Moved Amp entry above "Without initial prompt support" comment to correctly categorize it with providers that support initial prompts |
Sequence Diagram
sequenceDiagram
participant UI as TaskModal/ChatInterface
participant Registry as Provider Registry
participant PTY as PTY Manager
participant Amp as Amp CLI
Note over UI,Amp: User initiates task with Amp agent
UI->>Registry: Get provider definition for 'amp'
Registry-->>UI: ProviderDefinition with autoApproveFlag & initialPromptFlag
UI->>PTY: startDirectPty({providerId: 'amp', autoApprove: true, initialPrompt: '...'})
PTY->>Registry: Lookup PROVIDERS.find(p => p.id === 'amp')
Registry-->>PTY: Provider config with flags
Note over PTY: Build CLI arguments
PTY->>PTY: Add autoApproveFlag: '--dangerously-allow-all'
PTY->>PTY: Add initialPromptFlag: '' (positional arg)
PTY->>PTY: Add initialPrompt text
PTY->>Amp: Spawn: amp --dangerously-allow-all "task description"
Amp-->>PTY: Execute task with auto-approval enabled
Note over UI,Amp: Advanced features now work for Amp provider
Contributor
|
Hi @Klohto, thank you for opening this PR! LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Amp provider definition was missing
autoApproveFlagandinitialPromptFlag, which meant all the advanced task options (auto-approve, initial prompt, Linear/GitHub/Jira issue linking) were disabled when Amp was selected.Changes
autoApproveFlag: '--dangerously-allow-all'to the Amp provider entry inregistry.tsinitialPromptFlag: ''(empty string = positional argument, same convention as Codex/Claude)agentConfig.tsAll downstream UI and PTY logic is already provider-agnostic, so no additional code was needed.