Skip to content

fix: Remove tests and examples for deprecated models#1012

Merged
jakelorocco merged 15 commits intogenerative-computing:mainfrom
frreiss:drop_3.3
May 5, 2026
Merged

fix: Remove tests and examples for deprecated models#1012
jakelorocco merged 15 commits intogenerative-computing:mainfrom
frreiss:drop_3.3

Conversation

@frreiss
Copy link
Copy Markdown
Collaborator

@frreiss frreiss commented May 5, 2026 •
edited
Loading

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

Attribution

  • AI coding assistants used

frreiss added 7 commits May 1, 2026 21:37
@frreiss
Fix tests that fail on machines without GPUs
c4d9b47 
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
@frreiss
Merge branch 'main' into drop_3.3
5538377 
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
@frreiss
Fix warning
0140a1f 
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
@frreiss
Fix broken tests
ca6a74f 
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
@frreiss
Remove references to deprecated models in tests
46b556d 
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
@frreiss
Remove unused test files
85c3e22 
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
@frreiss
Merge branch 'main' into drop_3.3
0238e98 
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
@frreiss frreiss requested review from a team as code owners May 5, 2026 00:01
@frreiss frreiss requested review from ajbozarth and markstur May 5, 2026 00:01
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@frreiss frreiss changed the title Remove tests and examples for deprecated models fix: Remove tests and examples for deprecated models May 5, 2026
@github-actions github-actions Bot added the bug Something isn't working label May 5, 2026
ajbozarth
ajbozarth requested changes May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of items to fix or clarify before merge.

Comment thread docs/examples/intrinsics/README.md Outdated
Comment thread pyproject.toml Outdated
Comment thread mellea/stdlib/components/intrinsic/rag.py
Comment thread test/formatters/granite/test_intrinsics_formatters.py
jakelorocco
jakelorocco reviewed May 5, 2026
View reviewed changes
Comment thread docs/examples/intrinsics/README.md Outdated
Comment thread mellea/stdlib/components/intrinsic/guardian.py
Comment thread mellea/stdlib/components/intrinsic/rag.py
Comment thread test/formatters/granite/testdata/test_canned_input/uncertainty.json Outdated
Copy link
Copy Markdown
Contributor

@jakelorocco jakelorocco May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add tests back for a newer version of the uncertainty model later?

Copy link
Copy Markdown
Collaborator Author

@frreiss frreiss May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would probably be a good idea.

Comment thread test/stdlib/components/intrinsic/test_rag.py
Comment on lines +148 to +151
try:
assert result == expected
except AssertionError as ae:
pytest.xfail(f"Known differences across platforms. Diff was: {ae}")
Copy link
Copy Markdown
Contributor

@jakelorocco jakelorocco May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this to fix the version pinning / non-deterministic issues now. But some of our tests do sometimes fail because of different versions of the adapter. I'll take a look at #976 later to see what that solution is as well.

Comment thread pyproject.toml Outdated
@frreiss
Copy link
Copy Markdown
Collaborator Author

frreiss commented May 5, 2026

Upon further discussion, it appears that the actual requirement is to keep context relevance support around, but to disable it selectively for Granite 4.1 base models. This will require a different set of changes.

ajbozarth
ajbozarth reviewed May 5, 2026
View reviewed changes
Comment thread test/stdlib/components/intrinsic/test_rag.py Outdated
Comment thread test/stdlib/components/intrinsic/test_rag.py Outdated
ajbozarth
ajbozarth reviewed May 5, 2026
View reviewed changes
Comment thread test/formatters/granite/test_intrinsics_formatters.py Outdated
ajbozarth
ajbozarth approved these changes May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

posted a few nits, but otherwise everything is looking good

frreiss and others added 3 commits May 5, 2026 13:38
@frreiss @ajbozarth
Update test/stdlib/components/intrinsic/test_rag.py
dc91cc7 
Co-authored-by: Alex Bozarth <ajbozart@us.ibm.com>
@frreiss @ajbozarth
Update test/stdlib/components/intrinsic/test_rag.py
82eea75 
Co-authored-by: Alex Bozarth <ajbozart@us.ibm.com>
@frreiss
Update docstring
f49b497 
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
jakelorocco
jakelorocco approved these changes May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jakelorocco jakelorocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@jakelorocco jakelorocco added this pull request to the merge queue May 5, 2026
Merged via the queue into generative-computing:main with commit 64ff0ea May 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajbozarth ajbozarth ajbozarth approved these changes

@jakelorocco jakelorocco jakelorocco approved these changes

@markstur markstur Awaiting requested review from markstur markstur is a code owner automatically assigned from generative-computing/mellea-maintainers

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove tests and examples for deprecated models

3 participants

@frreiss @ajbozarth @jakelorocco