-
Notifications
You must be signed in to change notification settings - Fork 114
Bedrock aws access key #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leothomas
wants to merge
17
commits into
generative-computing:main
Choose a base branch
from
leothomas:bedrock_aws_access_key_id
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
66090ff
create_bedrock_mantle_backend -> create_bedrock_openai_backend
nrfulton caf816f
Hack in lieu of https://github.com/generative-computing/mellea/issues…
nrfulton 08eadf1
Adds support for IAM auth to Bedrock.
nrfulton d9deee4
fixes type error in bedrock.
nrfulton ff36f3b
adds litellm to model ids.
nrfulton 651a8cb
Add logprobs and retries support, add boto3 auth verification
leothomas 998e020
Update uv.lock
leothomas cf4768e
Updated from main fork
leothomas cbc436f
merged from main
leothomas a519865
Small fix
leothomas 12592f6
sync with upstream
leothomas 67a93ab
sync from upstream
leothomas c3ddb47
merge from main
leothomas 096d83a
Merge branch 'generative-computing:main' into bedrock_aws_access_key_id
leothomas f1d8103
Sync from upstream
leothomas 894dd39
Merge branch 'bedrock_aws_access_key_id' of github.com:leothomas/mell…
leothomas d9dbf3e
Remove old log supression
leothomas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajbozarth can you chime in on whether this something we should add a
motfield for instead of putting in_meta(cfGenerationMetadata)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It took some time to figure out exactly what I wanted to say, but I think I got Claude to summarize my thoughts correctly:
The pattern here would be
mot.logprobsrather than adding it intoGenerationMetadata(which holds execution metadata:
usage,model,provider, etc.). I'd lean towardkeeping it in
_metafor now for two reasons:non-streaming it's a single object. A public field needs a consistent, defined type.
by some backends. The existing public fields on
motare things every backend alwayspopulates.
If logprobs support expands to other backends, that would be the right time to define the
type and promote it to a real field — the same process the telemetry fields went through
before landing in
GenerationMetadata.