Add notification system for submission reviews #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Custom Notification model (temporary until django-notifications-hq supports Django 5.2)
- Bell icon with unread count and 30-second polling
- Notifications page with read/unread filtering
- Mark as read functionality with always-visible eye icon
- Currently triggers on submission accept/reject/more_info
- Clean UI matching project design (similar to SubmissionCard)
- Navigation: accepted/rejected → /my-submissions, more_info → /contributions/{id}
Note: Using custom implementation due to django-notifications-hq incompatibility with Django 5.2 (index_together deprecation issue).
Tracking issue: django-notifications/django-notifications#396
Closes #208
- Replace custom Notification model with django-notifications-hq - Install from GitHub commit for Django 5.2 support - Migrate 27 existing notifications with data preservation - Update views to use notify.send() signal instead of direct model creation - Add automated test suite in tests/ directory - Update serializers for GenericForeignKey compatibility
Collaborator
Author
|
Updated to django-notifications |
Collaborator
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Technical Implementation
Custom Notification Model (Temporary)
Using a custom model instead of
django-notifications-hqdue to Django 5.2 incompatibility. The package uses deprecatedindex_togetherwhich was removed in Django 5.2.Recent Development: Django 5.2 support was merged on July 15, 2025 (PR #405) and version 1.9.0 exists in the master branch with the fix. However, it's not officially released on PyPI yet (latest is 1.8.3 from October 2023).
Decision: Better to wait for the official 1.9.0 release rather than install from GitHub master. Will migrate to
django-notifications-hqonce officially published.Tracking: django-notifications/django-notifications#405
Next Steps
Notifications can be triggered from multiple places. Before adding more triggers, let's agree on UI/UX and decide all trigger points.
Closes #208