Skip to content

Add services.yaml to ssh_command Playwright test fixture#60

Merged
gensyn merged 1 commit into
mainfrom
copilot/update-hassfest-validator
May 13, 2026
Merged

Add services.yaml to ssh_command Playwright test fixture#60
gensyn merged 1 commit into
mainfrom
copilot/update-hassfest-validator

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 13, 2026

Hassfest scans all subdirectories of the integration path for manifest.json files, so tests/playwright/ssh_command/ is treated as a real integration. Its __init__.py registers an execute service, but the missing services.yaml caused Hassfest to fail — blocking HACS admission.

Changes

  • tests/playwright/ssh_command/services.yaml — adds the execute service definition matching the SERVICE_EXECUTE_SCHEMA already declared in the fixture's __init__.py (host, username, password, key_file, command, input, check_known_hosts, known_hosts, timeout)

@gensyn gensyn marked this pull request as ready for review May 13, 2026 18:25
Copilot AI review requested due to automatic review settings May 13, 2026 18:25
@gensyn gensyn merged commit 01a15ab into main May 13, 2026
5 checks passed
@gensyn gensyn deleted the copilot/update-hassfest-validator branch May 13, 2026 18:25
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the missing services.yaml to the Playwright ssh_command test fixture so Hassfest, which scans subdirectories for manifest.json, recognizes the execute service and stops failing — unblocking HACS admission.

Changes:

  • New services.yaml declaring the execute service with all nine fields from SERVICE_EXECUTE_SCHEMA (host, username, password, key_file, command, input, check_known_hosts, known_hosts, timeout), including matching defaults (check_known_hosts: true, timeout: 30).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants