feat: use react 19 by oterral · Pull Request #738 · geops/react-spatial

oterral · 2026-03-10T14:27:40Z

How to

BREAKING CHANGES: react-spatial now supports only react >= 19 , use version 2.x.x for react 18 support

Others

It's not a hack or at least an unauthorized hack :).
The images added are optimized.
Everything in ticket description has been fixed.
The author of the MR has made its own review before assigning the reviewer.
The title means something for a human being and follows the conventional commits specification.
The title contains [WIP] if it's necessary.
Labels applied. if it's a release? a hotfix?
Tests added.

vercel · 2026-03-10T14:27:47Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
react-spatial	Ready	Preview, Comment	Mar 11, 2026 7:04am

Copilot

Pull request overview

Updates the react-spatial package to require React 19+, modernizes tooling (ESLint 9 flat config, updated Jest config), and migrates repo workflows/docs from Yarn to pnpm.

Changes:

Bump React peer deps to ^19 and refresh related dependency/tooling versions.
Migrate scripts, docs, hooks, lint-staged, and CI from Yarn to pnpm (and add packageManager pin).
Adjust code/tests for new lint/runtime expectations (optional chaining, snapshot updates, test refactors).

Reviewed changes

Copilot reviewed 66 out of 71 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tsconfig.json	Adds TS config (noEmit/allowJs) to support updated tooling.
styleguide.config.js	Adds watch ignore patterns for faster styleguidist dev workflow.
src/utils/KML.js	Uses optional chaining to avoid null/undefined access.
src/styleguidist/StyleGuide.js	Refactors effects/refs for updated lint/runtime expectations.
src/styleguidist/ComponentsList.js	Removes unnecessary React import (new JSX runtime).
src/setupTests.js	Adds TextEncoder/TextDecoder globals for Jest environment.
src/components/Zoom/snapshots/Zoom.test.js.snap	Snapshot update for React/tooling changes.
src/components/Zoom/Zoom.test.js	Removes unnecessary async/await; lint suppressions added.
src/components/Zoom/Zoom.js	Removes eslint disable comment around prop spreading.
src/components/StopsFinder/snapshots/StopsFinder.test.js.snap	Snapshot update for React/tooling changes.
src/components/StopsFinder/StopsFinderOption.js	Refactors styled helper to satisfy linting.
src/components/StopsFinder/StopsFinder.js	Uses optional chaining for param serialization.
src/components/ScaleLine/snapshots/ScaleLine.test.js.snap	Snapshot header update.
src/components/ScaleLine/ScaleLine.test.js	Reorders imports (jest-canvas-mock).
src/components/ScaleLine/ScaleLine.js	Removes eslint disable comment around prop spreading.
src/components/RouteSchedule/RouteSchedule.test.js	Reorders imports (jest-date-mock).
src/components/RouteSchedule/RouteSchedule.js	Removes eslint disable comments around prop spreading.
src/components/ResizeHandler/ResizeHandler.test.js	Removes legacy eslint disables; minor cleanup.
src/components/ResizeHandler/ResizeHandler.js	Removes eslint disable comments around findDOMNode (commented code).
src/components/README.md	Updates component generator command to pnpm.
src/components/Popup/snapshots/Popup.test.js.snap	Snapshot header update.
src/components/Popup/Popup.test.js	Adds lint disables; optional chaining in teardown; moves jest-canvas-mock import.
src/components/Popup/Popup.js	Optional chaining for pixel array checks; removes eslint disable comment.
src/components/Permalink/Permalink.test.js	Reorders imports (jest-canvas-mock).
src/components/Permalink/Permalink.js	Removes eslint disable comments around param reassignment.
src/components/Overlay/snapshots/Overlay.test.js.snap	Snapshot header update.
src/components/NorthArrow/snapshots/NorthArrow.test.js.snap	Snapshot header update; removes one snapshot entry.
src/components/NorthArrow/NorthArrow.test.js	Reorders imports; removes one test; removes eslint disable comments.
src/components/NorthArrow/NorthArrow.js	Removes eslint disable comment around prop spreading.
src/components/MousePosition/snapshots/MousePosition.test.js.snap	Snapshot header update.
src/components/MousePosition/MousePosition.test.js	Reorders imports (jest-canvas-mock); removes eslint disable header.
src/components/MousePosition/MousePosition.js	Simplifies projection guard with optional chaining; removes eslint disable.
src/components/LayerTree/snapshots/LayerTree.test.js.snap	Snapshot header update.
src/components/LayerTree/LayerTree.test.js	Reorders imports; removes eslint disable header.
src/components/LayerTree/LayerTree.js	Refactors static helpers; uses optional chaining; removes some eslint disables.
src/components/Geolocation/snapshots/Geolocation.test.js.snap	Snapshot header update.
src/components/Geolocation/Geolocation.test.js	Reorders imports; optional chaining in teardown.
src/components/Geolocation/Geolocation.js	Removes eslint disable comment around prop spreading.
src/components/FitExtent/snapshots/FitExtent.test.js.snap	Snapshot header update; renames snapshot key.
src/components/FitExtent/FitExtent.test.js	Wraps tests in `describe` block; formatting cleanup.
src/components/FitExtent/FitExtent.js	Removes eslint disable comment around prop spreading.
src/components/FeatureExportButton/snapshots/FeatureExportButton.test.js.snap	Snapshot header update.
src/components/FeatureExportButton/FeatureExportButton.test.js	Reorders imports (jest-canvas-mock).
src/components/FeatureExportButton/FeatureExportButton.js	Removes eslint disable comments; keeps behavior.
src/components/Copyright/snapshots/Copyright.test.js.snap	Snapshot header update.
src/components/Copyright/Copyright.test.js	Reorders imports (jest-canvas-mock).
src/components/Copyright/Copyright.js	Refactors ref callback; removes eslint disable comment.
src/components/CanvasSaveButton/snapshots/CanvasSaveButton.test.js.snap	Snapshot header update.
src/components/CanvasSaveButton/CanvasSaveButton.test.js	Reorders imports; refactors async interactions.
src/components/CanvasSaveButton/CanvasSaveButton.js	Optional chaining for extraData; refactors array filtering; removes eslint disables.
src/components/BasicMap/BasicMap.test.js	Reorders imports (jest-canvas-mock).
src/components/BaseLayerSwitcher/BaseLayerSwitcher.test.js	Removes unnecessary async/await in fireEvent usage.
src/components/BaseLayerSwitcher/BaseLayerSwitcher.js	Removes eslint disable header/comments; keeps behavior.
scripts/read-pkg-json.js	Updates helper output from yarn commands to pnpm; formatting cleanup.
package.json	React 19 peer deps; pnpm migration; dependency/tooling bumps; adds `packageManager`.
jest.config.js	Updates transforms; removes unused moduleNameMapper entry.
eslint.config.mjs	Adds ESLint 9 flat config based on @geops/eslint-config-react.
doc/README.md	Updates dev command examples to pnpm.
README.md	Updates install command example to pnpm.
DEVELOP.md	Updates dev/test/coverage command examples to pnpm.
.nvmrc	Bumps Node version to 24.
.lintstagedrc.js	Runs related tests via pnpm instead of yarn.
.husky/post-rebase	Uses pnpm install after rebase.
.husky/post-merge	Uses pnpm install after merge.
.husky/post-checkout	Uses pnpm install after checkout.
.husky/commit-msg	Uses pnpm commitlint.
.gitignore	Ignores pnpm-workspace.yaml.
.github/workflows/main.yml	Switches CI commands from yarn to pnpm.
.eslintrc.js	Removes legacy ESLint config (replaced by flat config).

Comments suppressed due to low confidence (1)

src/components/CanvasSaveButton/CanvasSaveButton.test.js:135

This test schedules assertions inside window.setTimeout but does not wait for that callback to run. Jest can finish the test before the expectations execute, leading to false positives or flakiness. Use fake timers with jest.runAllTimers()/advanceTimersByTime, or return/await a Promise (or waitFor) that resolves after the timeout so the assertions are actually awaited.

    window.setTimeout(() => {
      expect(saveStart).toHaveBeenCalledTimes(1);
      expect(saveEnd).toHaveBeenCalledTimes(1);
      expect(link.href).toBe("http://localhost/fooblob");
      expect(link.download).toBe(".jpg");
      expect(link.click).toHaveBeenCalledTimes(1);
      spy3.mockRestore();
    });

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot · 2026-03-10T14:33:27Z

src/styleguidist/StyleGuide.js

          </Paper>
-          <div className={classes.scrollable} ref={(nodee) => setNode(nodee)}>
+          <div
+            className={classes.scrollable}
+            ref={(nodee) => {
+              return setNode(nodee);


Ref callback functions should not return a value. Returning setNode(nodee) is ignored by React but can be misleading and may violate lint rules; just call setNode(nodee) in the callback (or pass setNode directly).

Copilot · 2026-03-10T14:33:28Z

src/components/Copyright/Copyright.js

+      ref={(nod) => {
+        return setNode(nod);
+      }}


Ref callback functions should not return a value. Returning setNode(nod) is ignored by React and is misleading; call setNode(nod) without returning anything (or use ref={setNode} if appropriate).

Suggested change

ref={(nod) => {

return setNode(nod);

}}

ref={setNode}

Guess this makes sense

Copilot · 2026-03-10T14:33:28Z

.github/workflows/main.yml

      - name: Setup node
        uses: actions/setup-node@v3
        with:
          node-version-file: '.nvmrc'

      - name: Run linting and tests
        run: |
-          yarn install --frozen-lockfile
-          yarn lint
-          yarn test
+          pnpm install --frozen-lockfile
+          pnpm lint
+          pnpm test


CI now runs pnpm ... but the workflow does not install/activate pnpm (e.g., via corepack enable / corepack prepare pnpm@... --activate or pnpm/action-setup). On GitHub runners pnpm is not guaranteed to be available, so this job may fail.

Copilot · 2026-03-10T14:33:28Z

src/components/BaseLayerSwitcher/BaseLayerSwitcher.js

    }
-    // eslint-disable-next-line consistent-return
+
    return setSwitcherOpen(true) && setIsClosed(false);


setSwitcherOpen(true) && setIsClosed(false) will never call setIsClosed(false) because setSwitcherOpen returns undefined (falsy), so the && short-circuits. Call the setters in separate statements (and avoid returning their result) so both state updates happen reliably.

Suggested change

return setSwitcherOpen(true) && setIsClosed(false);

setSwitcherOpen(true);

setIsClosed(false);

Guess this makes sense

danji90

Mostly good. Just some cleaning and eslint warnings to fix, and the LayerTree example is in need of a fix. Otherwise LGTM

danji90 · 2026-03-11T12:03:32Z

src/components/BaseLayerSwitcher/BaseLayerSwitcher.test.js

@@ -1,3 +1,3 @@
 import { fireEvent, render } from "@testing-library/react";
 import Layer from "ol/layer/Layer";
 import React from "react";


danji90 · 2026-03-11T12:06:39Z

src/components/Copyright/Copyright.js

+      ref={(nod) => {
+        return setNode(nod);
+      }}


Guess this makes sense

danji90 · 2026-03-11T12:29:19Z

src/components/LayerTree/LayerTree.js

-    // ol.layer.group
-    layer?.getLayers?.().getArray() ||
-    [];
+  static getChildren = (layer) => {


Broken already before this update, but when you switch to Base Dark radio layer, then activate one of the checkbox child layers the base map is not set to visible and the map is white. Can you maybe fix this? Maybe we could even do a new example entirely, the current one is rather useless

oterral added 2 commits March 10, 2026 15:18

feat: use react 19

5ba9d88

build: use pnpm

e840500

vercel bot deployed to Preview March 10, 2026 14:27 View deployment

build: use node 24

d2bb0b4

oterral requested review from Copilot and danji90 and removed request for danji90 March 10, 2026 14:28

oterral self-assigned this Mar 10, 2026

Copilot started reviewing on behalf of oterral March 10, 2026 14:29 View session

vercel bot deployed to Preview March 10, 2026 14:30 View deployment

oterral added 4 commits March 10, 2026 15:31

Merge branch 'master' into olivier/react19

01a0a19

chore: update lock file

52c551e

chore(release): 2.1.0

c4dbb1a

chore(release): 2.1.1

80185e9

Copilot AI reviewed Mar 10, 2026

View reviewed changes

oterral added 2 commits March 10, 2026 15:34

chore(release): 2.1.2

ec962dc

chore(release): 2.1.3

2bd0d0d

vercel bot deployed to Preview March 10, 2026 14:35 View deployment

oterral added 3 commits March 10, 2026 15:35

chore(release): 2.1.4

873ac52

chore(release): 2.1.5

883201a

chore(release): 2.1.6

1998ee4

vercel bot deployed to Preview March 10, 2026 14:39 View deployment

oterral added 6 commits March 10, 2026 15:43

chore(release): 2.1.7-beta.0

b2f71e0

build: fix beta

71f8c48

chore(release): 2.1.7-beta.1

b9cd5a5

chore(release): 3.0.1-beta.0

8122139

build: fix beta

0fce596

chore(release): 3.0.1-beta.1

8e9e472

build: fix readme

64e0810

vercel bot deployed to Preview March 10, 2026 14:47 View deployment

vercel bot deployed to Preview March 10, 2026 14:48 View deployment

oterral added 2 commits March 10, 2026 15:49

build: fix peer

14a0cd5

chore(release): 3.0.1-beta.2

0db9476

vercel bot deployed to Preview March 10, 2026 14:51 View deployment

build: fix actions

5614652

vercel bot deployed to Preview March 10, 2026 14:56 View deployment

oterral added 2 commits March 10, 2026 15:57

build: fix actions

7119f1a

build: fix actions

3bc5c19

vercel bot deployed to Preview March 10, 2026 15:00 View deployment

fix: remove useless file

3f20a0c

vercel bot deployed to Preview March 10, 2026 15:09 View deployment

chore(release): 3.0.1-beta.3

b5718e9

vercel bot deployed to Preview March 10, 2026 15:13 View deployment

fix: remove useless package

6ac8af3

vercel bot deployed to Preview March 11, 2026 07:04 View deployment

danji90 requested changes Mar 11, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use react 19#738

feat: use react 19#738
oterral wants to merge 27 commits intomasterfrom
olivier/react19

oterral commented Mar 10, 2026 •

edited

Loading

Uh oh!

vercel bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 10, 2026

Uh oh!

Copilot AI Mar 10, 2026

Uh oh!

danji90 Mar 11, 2026

Uh oh!

Copilot AI Mar 10, 2026

Uh oh!

Copilot AI Mar 10, 2026

Uh oh!

danji90 Mar 11, 2026

Uh oh!

danji90 left a comment

Uh oh!

danji90 Mar 11, 2026

Uh oh!

danji90 Mar 11, 2026

Uh oh!

danji90 Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

	return setSwitcherOpen(true) && setIsClosed(false);
	setSwitcherOpen(true);
	setIsClosed(false);

Conversation

oterral commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to

Others

Uh oh!

vercel bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

danji90 Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

danji90 Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

danji90 left a comment

Choose a reason for hiding this comment

Uh oh!

danji90 Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

danji90 Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

danji90 Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

oterral commented Mar 10, 2026 •

edited

Loading

vercel bot commented Mar 10, 2026 •

edited

Loading