-
Notifications
You must be signed in to change notification settings - Fork 8
Update Quickstart for Android Kotlin to v5 #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Aaron LaBeau (biozal)
wants to merge
9
commits into
main
Choose a base branch
from
da-138-update-v5-kotlin-android
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
449afdb
feat: update to v5 of the API
biozal 922c5cd
Updated for RC3 support and Android best practices
biozal 8baf8c0
Updated to try and fix CI/CD Pipeline
biozal 90a3c7a
Merge branch 'main' into da-138-update-v5-kotlin-android
biozal 633807b
updated to v5 and improved code based on feedback
biozal e1a56eb
Potential fix for pull request finding
biozal 67736cc
Potential fix for pull request finding
biozal 1c64349
Potential fix for pull request finding
biozal 74a4305
updated to fix PR comments
biozal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 12 additions & 1 deletion
13
android-kotlin/QuickStartTasks/app/src/main/java/live/ditto/quickstart/tasks/DittoHandler.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,20 @@ | ||
| package live.ditto.quickstart.tasks | ||
|
|
||
| import live.ditto.* | ||
| import com.ditto.kotlin.* | ||
|
|
||
| class DittoHandler { | ||
| companion object { | ||
| lateinit var ditto: Ditto | ||
| private set | ||
|
|
||
| fun initialize(config: DittoConfig) { | ||
| if (::ditto.isInitialized) { | ||
| throw IllegalStateException("Ditto is already initialized") | ||
| } | ||
| ditto = DittoFactory.create(config = config) | ||
| } | ||
|
|
||
| val isInitialized: Boolean | ||
| get() = ::ditto.isInitialized | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.