Skip to content

fix(metrics): Gracefully handle errors when recording commit status metrics #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(metrics): Gracefully handle errors when recording commit status metrics #521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions arroyo/backends/kafka/consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,20 +273,30 @@ def __on_commit_callback(
tags = {"status": "error"}
if self.__group_id:
tags["group_id"] = self.__group_id
self.__metrics.increment(
name="arroyo.consumer.commit_status",
value=1,
tags=tags,
)
try:
self.__metrics.increment(
name="arroyo.consumer.commit_status",
value=1,
tags=tags,
)
except Exception as e:
logger.debug(
"Failed to record commit status metric: %s", e, exc_info=False
)
Comment on lines +276 to +285
Copy link
Member

@markstory markstory Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consolidate the try/except and metrics.increment() call as both sides of the branch have the same logic.

else:
tags = {"status": "success"}
if self.__group_id:
tags["group_id"] = self.__group_id
self.__metrics.increment(
name="arroyo.consumer.commit_status",
value=1,
tags=tags,
)
try:
self.__metrics.increment(
name="arroyo.consumer.commit_status",
value=1,
tags=tags,
)
except Exception as e:
logger.debug(
"Failed to record commit status metric: %s", e, exc_info=False
)

def __resolve_partition_offset_earliest(
self, partition: ConfluentTopicPartition
Expand Down