fix(updater): Select first matching main branch#165
Merged
Conversation
sentry-cli currently has main and master pointing at the same HEAD, so the updater emits both names in mainBranch output. Match that fixture output instead of requiring master only.
vaind
requested changes
May 7, 2026
jpnurmi
changed the title
Contributor
vaind
approved these changes
May 11, 2026
2 tasks
vaind
added a commit
that referenced
this pull request
May 11, 2026
…#167) The `writes output` / `writes to env:GITHUB_OUTPUT` tests assert against the live state of getsentry/sentry-cli via `git ls-remote`. Whether the script reports `main` or `master` depends on which of the two currently points at the upstream HEAD, which flips over time. PR #165 baked `main` into the assertion while both happened to point at HEAD; sentry-cli has since diverged and post-merge CI on main now reports `master`, failing the test. Accept either branch name so the test isn't coupled to transient upstream branch state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sentry-clicurrently hasmainandmasterpointing at the sameHEAD, so the updater started emitting both names inmainBranch=main masteroutput.