fix(artifacts): Report error for unknown artifact types in distribution#567
Open
runningcode wants to merge 6 commits intomainfrom
Open
fix(artifacts): Report error for unknown artifact types in distribution#567runningcode wants to merge 6 commits intomainfrom
runningcode wants to merge 6 commits intomainfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
runningcode
commented
Feb 23, 2026
| logger.info(f"BUILD_DISTRIBUTION for {artifact_id} (project: {project_id}, org: {organization_id})") | ||
| if isinstance(artifact, ZippedXCArchive): | ||
| apple_info = cast(AppleAppInfo, info) | ||
| if apple_info.is_code_signature_valid and not apple_info.is_simulator: |
Contributor
Author
There was a problem hiding this comment.
cursorbot said that if a ZippedXCArchive has an invalid code signature or simulator build, it silently does nothing so this addresses that.
runningcode
added a commit
to getsentry/sentry
that referenced
this pull request
Mar 5, 2026
Add a dedicated endpoint (`PUT
.../files/preprodartifacts/{id}/distribution/`) for launchpad to report
distribution processing errors back to the monolith. This mirrors the
existing `ProjectPreprodSizeEndpoint` pattern.
When launchpad encounters a distribution failure (unsupported artifact
type, invalid code signature, simulator build), it needs a way to set
`installable_app_error_code` and `installable_app_error_message` on the
artifact so the frontend can display the reason. Previously, the only
option was the general `update` endpoint which marks the entire artifact
as failed — but distribution errors shouldn't affect the artifact's
overall state.
Follow-up to #109062. The launchpad side that calls this endpoint is in
getsentry/launchpad#567.
Refs EME-842, EME-422
---------
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
JonasBa
pushed a commit
to getsentry/sentry
that referenced
this pull request
Mar 5, 2026
Add a dedicated endpoint (`PUT
.../files/preprodartifacts/{id}/distribution/`) for launchpad to report
distribution processing errors back to the monolith. This mirrors the
existing `ProjectPreprodSizeEndpoint` pattern.
When launchpad encounters a distribution failure (unsupported artifact
type, invalid code signature, simulator build), it needs a way to set
`installable_app_error_code` and `installable_app_error_message` on the
artifact so the frontend can display the reason. Previously, the only
option was the general `update` endpoint which marks the entire artifact
as failed — but distribution errors shouldn't affect the artifact's
overall state.
Follow-up to #109062. The launchpad side that calls this endpoint is in
getsentry/launchpad#567.
Refs EME-842, EME-422
---------
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
…on (EME-422) Replace the TODO in _do_distribution() with a call to _update_artifact_error() so that unsupported artifact types are properly reported back to Sentry instead of silently failing.
When a ZippedXCArchive has an invalid code signature or is a simulator build, _do_distribution now reports the specific error via _update_artifact_error instead of silently doing nothing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The update_artifact endpoint silently ignored distribution_state and distribution_skip_reason fields. Use the dedicated distribution endpoint that accepts error_code and error_message instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
runningcode
force-pushed
the
no/eme-422-update-artifact-error-unknown-type
branch
from
5eaf5cd to
fe8817e
Compare
…EME-422) Unsupported artifact types are genuine errors, not intentional skips. Report them with PROCESSING_ERROR instead of SKIPPED so they surface correctly to users. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Sentry Build Distribution
|
…ns (EME-422) Catch all exceptions (not just SentryClientError) when reporting distribution errors/skips. Network errors like ConnectionError and Timeout from requests aren't subclasses of SentryClientError, so they would propagate uncaught and crash the pipeline. These are best-effort notifications that should never block artifact processing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Sentry Build Distribution
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Unused
project_idparameter creates monitoring blind spot- Added StatsD metrics emission to _update_distribution_skip following the pattern of sibling methods to track distribution skip events with project_id, organization_id, and skip_reason tags.
Or push these changes by commenting:
@cursor push cbb5a57a4d
Preview (cbb5a57a4d)
diff --git a/src/launchpad/artifact_processor.py b/src/launchpad/artifact_processor.py
--- a/src/launchpad/artifact_processor.py
+++ b/src/launchpad/artifact_processor.py
@@ -433,6 +433,15 @@
skip_reason: str,
) -> None:
"""Report distribution skip via the dedicated distribution endpoint."""
+ self._statsd.increment(
+ "artifact.distribution.skipped",
+ tags=[
+ f"skip_reason:{skip_reason}",
+ f"project_id:{project_id}",
+ f"organization_id:{organization_id}",
+ ],
+ )
+
try:
self._sentry_client.update_distribution_error(
org=organization_id,| error_message=skip_reason, | ||
| ) | ||
| except Exception: | ||
| logger.exception(f"Failed to update distribution skip for artifact {artifact_id}") |
There was a problem hiding this comment.
Unused project_id parameter creates monitoring blind spot
Low Severity
_update_distribution_skip accepts project_id but never uses it. Every sibling error-reporting method (_update_artifact_error, _update_size_error) uses project_id for self._statsd.increment calls that track errors with project_id and organization_id tags. The new method emits no StatsD metrics at all, meaning distribution skip events are invisible to monitoring — unlike all other failure paths in this class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
_do_distribution()encounters an unknown artifact type, it only loggedan error but never reported the failure back to Sentry via
_update_artifact_error(). This left the artifact in an inconsistent statewhere distribution was requested but silently failed.
Now calls
_update_artifact_error()withARTIFACT_PROCESSING_ERROR/UNSUPPORTED_ARTIFACT_TYPEso the failure is surfaced to users.Fixes EME-422