fix: gate goblin logs before formatting#3238
Open
supervacuus wants to merge 3 commits intogetsentry:masterfrom
Open
fix: gate goblin logs before formatting#3238supervacuus wants to merge 3 commits intogetsentry:masterfrom
supervacuus wants to merge 3 commits intogetsentry:masterfrom
Conversation
This was referenced Mar 24, 2026
loewenheim
approved these changes
Mar 26, 2026
Author
|
@loewenheim, thx! Since Danger complains, does this justify an entry into the changelog? |
loewenheim
added
the
skip-changelog
Contributor
No, I don't think so. I applied the label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As evaluated in the context of #3237, in some configurations, just formatting the
goblinlogs can be costly enough to become a performance issue.This PR moves the logging gate for
goblinintoenabled()so that we discard its logs before we format them.Issues
Raised as part of the fixes for getsentry/sentry#104738
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.