Skip to content

fix(code-mappings): Add path validation to prevent path traversal #3242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fix-it-felix-sentry wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −1
Open

fix(code-mappings): Add path validation to prevent path traversal #3242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/commands/code_mappings/upload.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
use std::fs;
use std::path::Path;

use anyhow::{bail, Context as _, Result};
use clap::{Arg, ArgMatches, Command};
Expand Down Expand Up @@ -45,7 +46,13 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
let path = matches
.get_one::<String>("path")
.expect("path is a required argument");
let data = fs::read(path).with_context(|| format!("Failed to read mappings file '{path}'"))?;

// Validate and canonicalize the path to prevent path traversal attacks
let canonical_path = Path::new(path)
.canonicalize()
.with_context(|| format!("Failed to resolve path '{path}'. Ensure the file exists and is accessible."))?;

let data = fs::read(&canonical_path).with_context(|| format!("Failed to read mappings file '{}'", canonical_path.display()))?;

let mappings: Vec<BulkCodeMapping> =
serde_json::from_slice(&data).context("Failed to parse mappings JSON")?;
Expand Down