Update size analysis to be shown in beta #15859
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| sidebar_order: node.frontmatter.sidebar_order, | ||
| sidebar_title: node.frontmatter.sidebar_title, | ||
| sidebar_hidden: node.frontmatter.sidebar_hidden, | ||
| beta: node.frontmatter.beta, | ||
| new: node.frontmatter.new, | ||
| section_end_divider: node.frontmatter.section_end_divider, | ||
| sidebar_section: node.frontmatter.sidebar_section, | ||
| }, | ||
| path: '/' + node.path + '/', | ||
| }); |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| isActive={!isPlatformSidebar && unversionedPath === root} | ||
| topLevel | ||
| beta={parentNode.node?.context.beta} | ||
| isNew={parentNode.node?.context.new} |
There was a problem hiding this comment.
Bug: Beta badge uses wrong node, will never display
The beta and isNew props are sourced from parentNode.node?.context, but parentNode is the empty-named child entity whose node is always null due to how toTree constructs the tree. The actual frontmatter data with beta: true is on entity.node, not parentNode.node. This means the beta badge will never appear on section headers like "Size Analysis" even though the frontmatter is correctly set. The code should use entity.node?.context.beta and entity.node?.context.new instead, consistent with how title is retrieved on line 255.
| description: "Learn about managing the release ID and customizing Spring Boot to your organization's needs." | ||
| --- | ||
|
|
||
| Sentry's Spring Boot integration automatically includes the release and sets options as described in the following sections. |
There was a problem hiding this comment.
Bug: Unrelated trailing whitespace change in Spring Boot file
This file has a trailing space added that is unrelated to the PR's purpose of updating size analysis to beta. The advanced-usage.mdx file for Spring Boot documentation was likely open in an editor and inadvertently modified while working on the size analysis changes.
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES