Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Comment on lines
+11
to
14
| const SENTRY_API_SCHEMA_SHA = 'c40007183d071d4ef28a886be883697cc4fde251'; | ||
|
|
||
| const activeEnv = process.env.GATSBY_ENV || process.env.NODE_ENV || 'development'; | ||
|
|
There was a problem hiding this comment.
Bug: The resolveOpenAPI function does not check if the fetch request for the API schema is successful before parsing the response as JSON, risking a crash.
Severity: MEDIUM
Suggested Fix
Before calling response.json(), add a check to verify the response was successful. If !response.ok, throw a descriptive error to handle the failure gracefully. For example: if (!response.ok) { throw new Error(Failed to fetch API schema: ${response.statusText}); }.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: src/build/resolveOpenAPI.ts#L11-L14
Potential issue: The `resolveOpenAPI` function fetches an API schema from a raw content
URL. It directly calls `response.json()` on the fetch response without first checking if
the request was successful via `response.ok`. If the fetch fails for any reason, such as
a network error, an invalid commit SHA, or the file not being present at that commit,
the server will likely return a non-JSON response (e.g., a 404 HTML page). Attempting to
parse this response as JSON will cause an unhandled `SyntaxError`, leading to a crash in
the build process or at runtime.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.