Skip to content

Bump API schema to 508ff446#16619

Open
getsantry[bot] wants to merge 1 commit intomasterfrom
bot/bump-api-schema-to-508ff446
Open

Bump API schema to 508ff446#16619
getsantry[bot] wants to merge 1 commit intomasterfrom
bot/bump-api-schema-to-508ff446

Conversation

@getsantry
Copy link
Contributor

@getsantry getsantry bot commented Feb 27, 2026

No description provided.

@getsantry getsantry bot enabled auto-merge (squash) February 27, 2026 23:03
@vercel
Copy link

vercel bot commented Feb 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
develop-docs Building Building Preview, Comment Feb 27, 2026 11:03pm
sentry-docs Building Building Preview, Comment Feb 27, 2026 11:03pm

Request Review

Comment on lines 12 to 14

const activeEnv = process.env.GATSBY_ENV || process.env.NODE_ENV || 'development';

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The fetch call in resolveOpenAPI lacks error handling for non-200 responses, which can cause the build process to fail if the remote file is unavailable.
Severity: MEDIUM

Suggested Fix

Check the response.ok property after the fetch call. If the response is not okay, throw a more informative error or handle it gracefully to prevent the build from crashing with an unhandled exception.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: src/build/resolveOpenAPI.ts#L12-L14

Potential issue: The `fetch` call in `resolveOpenAPI.ts` to retrieve
`openapi-derefed.json` from GitHub does not handle potential HTTP errors. If the fetch
fails due to network issues, an invalid commit SHA, or GitHub returning a non-200 status
code (e.g., 404, 500), the subsequent call to `response.json()` will throw an unhandled
exception. This will cause the entire static site generation process to fail, preventing
deployment. While this is a build-time failure, it introduces fragility into the build
pipeline.

Did we get this right? 👍 / 👎 to inform future reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants