feat: Add strict trace continuation support#4972
Closed
Conversation
Extract org ID from DSN host, add StrictTraceContinuation and OrgId options, propagate org_id in Dynamic Sampling Context, and validate incoming traces per the decision matrix. Closes #4963
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Features ✨
Fixes 🐛
Dependencies ⬆️Deps
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
|
The test project does not have nullable reference types enabled, so string? and BaggageHeader? annotations cause CS8632 errors.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
Closing in favor of a new implementation attempt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closed ... followed-up by #4981 after merging #4974
Summary
o123.ingest.sentry.io→"123")StrictTraceContinuation(bool, default false) andOrgId(string?) options toSentryOptionsorg_idin Dynamic Sampling Context / baggageDecision Matrix
Changes
Dsn.cs— org ID extraction from host using^o(\d+)\.regexSentryOptions.cs—StrictTraceContinuation,OrgId, andEffectiveOrgIdDynamicSamplingContext.cs—org_idin DSC itemsSentryPropagationContext.cs—ShouldContinueTrace()logic inCreateFromHeaders()Hub.cs— pass options toCreateFromHeaders()Test plan
Closes #4963
🤖 Generated with Claude Code