Skip to content

docs: document Directory.Build.props/targets hierarchy in agent instruction files #4984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescrosswell merged 3 commits into from
Mar 5, 2026
+6 −0
Merged

docs: document Directory.Build.props/targets hierarchy in agent instruction files #4984

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8021322
Initial plan
Copilot Mar 4, 2026
2225dde
docs: add Directory.Build.props/targets hierarchy guidance to agent i…
Copilot Mar 4, 2026
a6e918f
Made the instructions more concise
jamescrosswell Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ Uses the .NET SDK (`dotnet` CLI). Key files:
- `global.json` — pins .NET SDK and Workload versions
- `Directory.Build.props` / `Directory.Build.targets` — shared MSBuild properties across all projects

### MSBuild hierarchical structure

MSBuild searches upward from each project file and uses the **nearest** `Directory.Build.props`/`.targets` it finds. Parent files are not automatically included. props/targets files in this repo explicitly `<Import>` parent/root files when appropriate.
Copy link
Copy Markdown
Member

@Flash0ver Flash0ver Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: link to Microsoft docs

Shall we have a markdown link to the MSBuild docs?
https://learn.microsoft.com/visualstudio/msbuild/customize-by-directory?view=visualstudio#directorybuildprops-and-directorybuildtargets

Or would links in AGENTS.md just clutter the context?

Copy link
Copy Markdown
Collaborator

@jamescrosswell jamescrosswell Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The risk is that it follows the link, which will slow it down and add way more context than we really want... so no, I don't think we want to do that. If it keeps stuffing things up re props/targets files even with these instructions, I think we should look at improving these summary/concise instructions rather than linking to docs that are designed to be read by humans.


`integration-test/Directory.Build.props` / `integration-test/Directory.Build.targets` are intentionally isolated (do not import root).

## Solution Filters

Use solution filters instead of the full `Sentry.slnx`:
Expand Down
Loading