Skip to content

fix: Missing runtime dependency for Profiling on non-Windows environments#4999

Draft
Flash0ver wants to merge 3 commits intomainfrom
fix/profiling-non-windows
Draft

fix: Missing runtime dependency for Profiling on non-Windows environments#4999
Flash0ver wants to merge 3 commits intomainfrom
fix/profiling-non-windows

Conversation

@Flash0ver
Copy link
Member

@Flash0ver Flash0ver commented Mar 10, 2026

fixes #4815

TODO

  • Add Integration Test
  • Reproduce expected failure in CI
  • Fix the issue

Add a shared DotnetRun function to common.ps1 that wraps 'dotnet run' with
GitHub Actions log grouping and stderr capture. Fix a bug where the application
arguments were not expanded correctly in the command string due to missing
subexpression syntax ($()) inside the double-quoted string.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Flash0ver Flash0ver self-assigned this Mar 10, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Features ✨

  • feat: Network calls for Session Replay on Android by jamescrosswell in #4860

Fixes 🐛

  • fix: Missing runtime dependency for Profiling on non-Windows environments by Flash0ver in #4999
  • fix: Log Warning instead of Error when ratelimited by bitsandfoxes in #4927

Dependencies ⬆️

Deps

  • chore(deps): update Java SDK to v8.34.1 by github-actions in #4986
  • chore(deps): update CLI to v3.3.0 by github-actions in #4973
  • chore(deps): update Native SDK to v0.13.1 by github-actions in #4964
  • chore(deps): update Cocoa SDK to v9.5.0 by github-actions in #4944
  • chore(deps): update Native SDK to v0.13.0 by github-actions in #4941
  • chore(deps): update CLI to v3.2.2 by github-actions in #4943
  • chore(deps): update Java SDK to v8.33.0 by github-actions in #4933
  • chore(deps): update CLI to v3.2.0 by github-actions in #4805
    • NOTE: Sentry CLI v3 removed support for the legacy API key authentication method. Sentry CLI now only supports authenticating with Auth Tokens. If you are using API key authentication via SentryApiKey, you need to generate an Auth Token and use SentryAuthToken, instead.
  • chore(deps): update Cocoa SDK to v9.4.1 by github-actions in #4928
  • chore(deps): update Native SDK to v0.12.8 by github-actions in #4929
  • Apps built using the Sentry SDK for .NET must now target iOS version 15 or higher. Previously only version 13 or higher was required. (#4781) by github-actions in #4781
  • Bump Cocoa SDK from v8.57.3 to v9.2.0 (#4781) by github-actions in #4781
  • chore(deps): update Native SDK to v0.12.7 by github-actions in #4920

Other

  • chore: Set up dotagents with agent skills by Flash0ver in #4988
  • ref: align internal analyzer project with public compiler extensions by Flash0ver in #4842
  • style: file nesting by Flash0ver in #4894
  • ci: move from dotnet-format tool to .NET SDK command by Flash0ver in #4918
  • test(blazor): Add Playwright E2E tests for navigation breadcrumbs by bruno-garcia in #4908
  • test(android): Use volatile to produce SIGSEGV in native crash test by jpnurmi in #4919

🤖 This preview updates automatically when you update the PR.

@Flash0ver Flash0ver changed the title test(integration-test): Add Integration Test for Sentry.Profiling fix: Missing runtime dependency for Profiling on non-Windows environments Mar 10, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Fixes

- Missing runtime dependency for Profiling on non-Windows environments ([#4999](https://github.com/getsentry/sentry-dotnet/pull/4999))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 772954a

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.90%. Comparing base (7feb9a6) to head (772954a).

Files with missing lines Patch % Lines
...ry.Profiling/SamplingTransactionProfilerFactory.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4999   +/-   ##
=======================================
  Coverage   73.89%   73.90%           
=======================================
  Files         496      496           
  Lines       17951    17951           
  Branches     3516     3516           
=======================================
+ Hits        13265    13266    +1     
+ Misses       3825     3824    -1     
  Partials      861      861           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sentry profiling depends on Windows specific library "Dia2Lib"

1 participant