chore: Update Polyfill from 1.32.0 to 1.33.2#5007
Open
Conversation
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Features ✨
Fixes 🐛
Dependencies ⬆️Deps
Other
🤖 This preview updates automatically when you update the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5007 +/- ##
==========================================
- Coverage 73.90% 73.89% -0.01%
==========================================
Files 497 497
Lines 17957 17957
Branches 3516 3516
==========================================
- Hits 13271 13270 -1
Misses 3825 3825
- Partials 861 862 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Flash0ver
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update
Polyfillto the latest version possible without a Breaking Change for our scenario.Remarks
Replacement for #4879, as updating to a newer version yields a possible Dependency-Breaking Change for .NET Framework applications.
Follow-up: #5006, targeted for our next Major release.
Changes: SimonCropp/Polyfill@1.32.0...1.33.1
The only notable change is a bug-fix for a Polyfill-method, that we currently don't seem to be impacted by:
public static Task<string> ReadLineAsync(this TextReader target, CancellationToken cancellationToken)So we can actually take or leave this PR.
I'd still like to take it, should we start using the impacted method between now and #5006.