fix: prevent race condition when span count approaches the 1000-span limit#5227
Merged
jamescrosswell merged 2 commits intoMay 13, 2026
Merged
Conversation
…limit Wraps AddChildSpan in a lock so concurrent span creation cannot exceed the limit or set IsSampled incorrectly under contention. Fixes #5173 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Resolved conflict in AddChildSpan: moved span limit check inside _finishLock so the race condition fix and the finish/idle-timeout guard share a single lock, removing the need for a separate _childSpanLock. Kept SpanLimit constant and debug logging from the target branch. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## maui-trace-ui-5116 #5227 +/- ##
=====================================================
Coverage ? 74.05%
=====================================================
Files ? 502
Lines ? 18261
Branches ? 3571
=====================================================
Hits ? 13523
Misses ? 3863
Partials ? 875 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddChildSpanin aLockso concurrent span creation cannot race past the 1000-span ceiling or incorrectly setIsSampledunder contentionStartChild_Limit_Maintained_Concurrentlytest usingParallel.Forto reproduce the raceFixes #5173
Targets #5138 (
maui-trace-ui-5116) — intended to be merged there rather than directly to main.🤖 Generated with Claude Code