Skip to content

build: enable CA2007 enforcement via nested src/.editorconfig #5230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jamescrosswell wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −6
Draft

build: enable CA2007 enforcement via nested src/.editorconfig #5230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Settings that apply only to library code under /src
# (so tests, samples, benchmarks, and integration-tests are not affected).

[*.cs]

# CA2007: Consider calling ConfigureAwait on the awaited task.
# Library code must always ConfigureAwait(false) to avoid deadlocks in
# callers that have a SynchronizationContext.
dotnet_diagnostic.CA2007.severity = error
5 changes: 0 additions & 5 deletions src/CodeAnalysis.ruleset
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
<IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion>

<Nullable>annotations</Nullable>
<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)CodeAnalysis.ruleset</CodeAnalysisRuleSet>
</PropertyGroup>

<!-- Centralise logic for enabling `IsAotCompatible`. We use this to disable Aot for the device tests, for example -->
Expand Down
Loading