Support apps compiled against Jetpack Compose 1.10#5189
Draft
Support apps compiled against Jetpack Compose 1.10#5189
Conversation
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- Support apps compiled against Jetpack Compose 1.10 ([#5189](https://github.com/getsentry/sentry-java/pull/5189))If none of the above apply, you can opt out of this check by adding |
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee747ae | 357.79 ms | 421.84 ms | 64.05 ms |
| 22f4345 | 307.87 ms | 354.51 ms | 46.64 ms |
| dc4cc7a | 361.10 ms | 439.53 ms | 78.43 ms |
| a416a65 | 316.52 ms | 359.67 ms | 43.15 ms |
| d15471f | 310.66 ms | 368.19 ms | 57.53 ms |
| 9fbb112 | 361.43 ms | 427.57 ms | 66.14 ms |
| dba088c | 328.51 ms | 423.79 ms | 95.28 ms |
| 27d7cf8 | 397.90 ms | 498.65 ms | 100.75 ms |
| 951caf7 | 323.66 ms | 392.82 ms | 69.16 ms |
| a416a65 | 295.53 ms | 373.74 ms | 78.21 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 22f4345 | 1.58 MiB | 2.29 MiB | 719.83 KiB |
| dc4cc7a | 1.58 MiB | 2.19 MiB | 619.28 KiB |
| a416a65 | 1.58 MiB | 2.12 MiB | 555.26 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| 9fbb112 | 1.58 MiB | 2.11 MiB | 539.18 KiB |
| dba088c | 1.58 MiB | 2.13 MiB | 558.99 KiB |
| 27d7cf8 | 1.58 MiB | 2.12 MiB | 549.42 KiB |
| 951caf7 | 1.58 MiB | 2.13 MiB | 558.77 KiB |
| a416a65 | 1.58 MiB | 2.12 MiB | 555.26 KiB |
Sentry Build Distribution
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixes #5086
Starting with Jetpack Compose 1.10, some internal APIs JVM methods dropped the
_release()suffix. E.g.getChildren$ui()instead of previousgetChildren$ui_release().This PR wraps those methods, as a compat layer - so they work across multiple versions during runtime.
It required some "extra" gradle setup (as AGP does not seem to support different class paths per source set), but seems to work well in initial testing.
Some more (automated) testing is required before this can be merged.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps