fix(nextjs): preserve directive prologues in turbopack loaders#20103
Closed
igz0 wants to merge 1 commit intogetsentry:developfrom
Closed
fix(nextjs): preserve directive prologues in turbopack loaders#20103igz0 wants to merge 1 commit intogetsentry:developfrom
igz0 wants to merge 1 commit intogetsentry:developfrom
Conversation
|
This PR has been automatically closed. The referenced issue does not show a discussion between you and a maintainer. To avoid wasted effort on both sides, please discuss your proposed approach in the issue first and wait for a maintainer to respond before opening a PR. Please review our contributing guidelines for more details. |
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Deps
Other
Bug Fixes 🐛
Internal Changes 🔧Core
Deps
Other
🤖 This preview updates automatically when you update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20101.
Summary
When
_experimental.turbopackApplicationKeyis enabled, the Next.js Turbopack loaders inject code for metadata/value propagation.The previous implementation relied on a regex that only handled a single directive prologue entry. For modules that start with multiple directives, such as:
the injected code could end up between the directives and break the
"use client"classification.This replaces the regex-based insertion point detection with a small linear scanner that:
Tests
Verification
Using the reproduction from #20101 with the patched
@sentry/nextjstarball:npm run buildcompletes successfully/_not-foundprerendering succeedsTypeError: (0, g.useEffect) is not a functionno longer occurs